This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
fix memory corruption in gluoncv ssd training #13727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhreshold
approved these changes
Dec 25, 2018
|
LGTM, thanks @arcadiaphy |
| @@ -785,7 +785,7 @@ void BipartiteMatchingForward(const nnvm::NodeAttrs& attrs, | |||
| .get_with_shape<xpu, 2, DType>(Shape2(batch_size, col), s); | |||
| Shape<1> sort_index_shape = Shape1(dshape.Size()); | |||
| index_t workspace_size = sort_index_shape.Size(); | |||
| workspace_size += ((sort_index_shape.Size() * sizeof(int32_t) - 1) / sizeof(DType)) * 2; | |||
| workspace_size += (sort_index_shape.Size() * 2 * sizeof(int32_t) - 1) / sizeof(DType) + 1; | |||
There was a problem hiding this comment.
Sorry for my naive understanding. But, I do not understand why +1? And this mean, we will have one extra size in the workspace always?
There was a problem hiding this comment.
Yes, we will have extra size sometimes when we need to hold int32_t data in DType workspace, and the calculation assures that only the smallest needed space is allocated.
if workspace = (N * sizeof(int32_t) - 1) / sizeof(DType) + 1,
then workspace * sizeof(DType) >= N * sizeof(int32_t) - 1 - (sizeof(DType) - 1) + sizeof(DType)
= N * sizeof(int32_t)
Actually, L426 has already calculated correctly.
sandeep-krishnamurthy
added
Backend
|
Is it better to create two workspaces for DType and int32_t respectively? |
|
workspace allocation is limited to one time only, so total space has to be calculated aforehead |
|
@zhreshold Thanks! |
|
@zhreshold Is this PR good to go? |
rondogency
pushed a commit
to rondogency/incubator-mxnet
that referenced
this pull request
Jan 9, 2019
This was referenced Jan 16, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #13710
In bipartite match, the temporary workspace size is miscalculated and not enough to hold the index tensor.
Since it is related to
sizeof(DType)andsizeof(int32_t), the bug is only triggered on some platforms.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments